skpkg: run package update for skpkg 0.3.0#164
Conversation
|
@sbillinge ready for review. Looks like pre-commit was out of date a bit too so some pre-commit edits were made by the bot |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.3.0 #164 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 25 25
Lines 3832 3832
=======================================
Hits 2773 2773
Misses 1059 1059
🚀 New features to boost your workflow:
|
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
This looks great!
please see inline comment
please check if there are any CI workflows that need to be deleted, replaced with the new ones here.
| # See LICENSE.rst for license information. | ||
| # | ||
| ############################################################################## | ||
| """Complex modeling framework for structure refinement and solution. |
There was a problem hiding this comment.
Please check, do we want to lose this text?
There was a problem hiding this comment.
@sbillinge we are moving to just having the brief description here. I moved this to the README (A better place for it to live imo)
@sbillinge good catch, thanks! This is failing pre-commit docformatting, I think maybe because of this merge #165 ? Not sure though Can we merge this first, then i'll figure out whats causing this to fail? |
@sbillinge confirmed, it is because of this. I merged from upstream. Now its passing! |
2 participants
Added a new copyright,